Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playground: support ticdc for playground #777

Merged
merged 7 commits into from
Sep 14, 2020
Merged

playground: support ticdc for playground #777

merged 7 commits into from
Sep 14, 2020

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

support ticdc for playground

What is changed and how it works?

➜  tiup git:(master) ✗ tiup playground --tiflash 0 --ticdc 1
Starting component `playground`: /Users/leoppro/.tiup/components/playground/v1.1.2/tiup-playground --tiflash 0 --ticdc 1
Use the latest stable version: v4.0.5

    Specify version manually:   tiup playground <version>
    The stable version:         tiup playground v4.0.0
    The nightly version:        tiup playground nightly

Playground Bootstrapping...
Start pd instance
Start tikv instance
Start tidb instance
Start ticdc instance
Waiting for tidb 127.0.0.1:4000 ready  ... ⠏ 
Waiting for tidb 127.0.0.1:4000 ready  ... Done
CLUSTER START SUCCESSFULLY, Enjoy it ^-^
To connect TiDB: mysql --host 127.0.0.1 --port 4000 -u root
To view the dashboard: http://127.0.0.1:2379/dashboard
To view the Prometheus: http://127.0.0.1:9090
To view the Grafana: http://127.0.0.1:3000


➜  tiup git:(master) ✗ tiup playground scale-out --ticdc 2
Starting component `playground`: /Users/leoppro/.tiup/components/playground/v1.1.2/tiup-playground scale-out --ticdc 2
➜  tiup git:(master) ✗ tiup playground display                                      
Starting component `playground`: /Users/leoppro/.tiup/components/playground/v1.1.2/tiup-playground display
Pid    Role   Uptime
---    ----   ------
40091  pd     31.010579721s
40092  tikv   31.003603491s
40093  tidb   30.998851345s
40094  ticdc  30.992450324s
41704  ticdc  13.818018056s
41705  ticdc  13.813229267s

➜  tiup git:(master) ✗ tiup playground scale-in --pid 41704
Starting component `playground`: /Users/leoppro/.tiup/components/playground/v1.1.2/tiup-playground scale-in --pid 41704
scale in ticdc success
➜  tiup git:(master) ✗ tiup playground display             
Starting component `playground`: /Users/leoppro/.tiup/components/playground/v1.1.2/tiup-playground display
Pid    Role   Uptime
---    ----   ------
40091  pd     15m22.272593345s
40092  tikv   15m22.265617458s
40093  tidb   15m22.260864378s
40094  ticdc  15m22.254463605s
41705  ticdc  15m5.0752401s

Release notes:

Support TiCDC for playground

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2020 •
edited
Loading

Codecov Report

Merging #777 into master will decrease coverage by 0.14%.
The diff coverage is 6.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage   54.70%   54.56%   -0.15%     
==========================================
  Files         260      261       +1     
  Lines       21080    21142      +62     
==========================================
+ Hits        11532    11536       +4     
- Misses       7999     8054      +55     
- Partials     1549     1552       +3
Flag Coverage Δ
#cluster 46.84% <ø> (ø)
#dm 26.92% <ø> (ø)
#integrate 49.85% <6.45%> (-0.13%) ⬇️
#playground 22.92% <6.45%> (-0.15%) ⬇️
#tiup 19.80% <ø> (ø)
#unittest 19.46% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/playground.go 40.53% <0.00%> (-1.18%) ⬇️
components/playground/command.go 60.27% <25.00%> (-2.05%) ⬇️
components/playground/main.go 70.83% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b1ade...0d93e71. Read the comment docs.

july2993
july2993 reviewed Sep 12, 2020
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

components/playground/instance/ticdc.go Outdated Show resolved Hide resolved
components/playground/instance/ticdc.go Show resolved Hide resolved
components/playground/instance/ticdc.go Outdated Show resolved Hide resolved
@july2993 july2993 added status/PTAL type/new-feature Categorizes pr as related to a new feature. labels Sep 12, 2020
@zier-one
Copy link
Contributor Author

@july2993 @lonng PTAL again

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
@july2993 july2993 merged commit 2850c53 into pingcap:master Sep 14, 2020
@zier-one zier-one deleted the support_cdc_for_playground branch September 14, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zier-one @CLAassistant @codecov-commenter @july2993 @ti-srebot @lonng